Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download progress bar shows incorrect values #2087

Merged
merged 15 commits into from
Jul 30, 2023
Merged

Download progress bar shows incorrect values #2087

merged 15 commits into from
Jul 30, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jul 20, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@sarao1310 sarao1310 changed the base branch from v2 to dev July 20, 2023 11:23
@sarao1310 sarao1310 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@eyalbe4 eyalbe4 changed the title Bug fix : the download general progress bar shows incorrect values Download progress bar shows incorrect values Jul 22, 2023
eyalbe4
eyalbe4 requested changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem to fix the issue. The nominator of the Totals label remains with a zero value.
image

@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@sarao1310 sarao1310 requested a review from eyalbe4 July 24, 2023 10:03
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 30, 2023
@sarao1310 sarao1310 merged commit d8ebef4 into jfrog:dev Jul 30, 2023
55 of 59 checks passed
@chenrui333 chenrui333 mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@talarian1 talarian1 Awaiting requested review from talarian1

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarao1310 @eyalbe4